[MPlayer-dev-eng] [PATCH] Remove duplicated CPU detection in libmpeg2
jserv at linux2.cc.ntu.edu.tw
jserv at linux2.cc.ntu.edu.tw
Thu Jun 15 17:18:48 CEST 2006
On Thu, Jun 15, 2006 at 05:08:30PM +0200, Michael Niedermayer wrote:
> and its still not correct for MMX2 + 3dnow cpus, or SSE2 + 3dnow
> and the code is getting more and more messy for a trivial
>
> if(mmx) flags |= MMX;
> if(3dnow) flags |= 3DNOW;
> ...
> return flags
>
> and please no 20 #ifdefs around each if()
hi Michael,
Thanks for pointing me of the issue. However, I think the detection
should be trivial since there are few corresponding accelerated
implementations for idct and motion compensation in libmpeg2.
Ought to enumeration all possibility or not, I am wondering, and I
appreciate the discussion in MPlayer mailing-list.
Sincerely,
Jim Huang (jserv)
http://jserv.sayya.org/
More information about the MPlayer-dev-eng
mailing list