[MPlayer-dev-eng] [BUG][PATCH] uninitialized memory access in subreader.c

Ivan Kalvachev ikalvachev at gmail.com
Wed Jun 14 13:11:09 CEST 2006


2006/6/13, Evgeniy Stepanov <eugeni.stepanov at gmail.com>:
> On Tuesday 13 June 2006 16:22, Ivan Kalvachev wrote:
> > I don't mind the second one, but I think it is useless ATM.
> > The filename is guranteed to be more than 4 chars, this means 5 chars
> > at least, wihout counting the additinal zero byte. So even in the case
> > of the 6 char ".utf-8" the strcmp should work.
>
> With filename like "1.sub", filename+(l - strlen(exts[k])) points 1 byte
> _before_ the filename. That address could easily be unallocated.

My bad.
You are right.

Well, Poirier, will you commit them?



More information about the MPlayer-dev-eng mailing list