[MPlayer-dev-eng] Re: [PATCH] Use libunrar when available (2nd try)

[Guillaume POIRIER]

Hi,

On 6/14/06, Zuxy Meng <zuxy.meng at gmail.com> wrote:
> Hi,
>
> 2006/6/14, Guillaume POIRIER <poirierg at gmail.com>:
> > Hi,
> >
> >
> > We clearly haven't been following the our own policy regarding exported libs...
> >
> > So IMHO, I see no reason to ask you to provide a diff between official
> > and forked version. (which doesn't mean that you aren't welcome to do
> > it though).
> > BTW: in order to restate what Reimar meant: the patches we keep in our
> > tree are meant to be used to be able to see what we modified without
> > the need of comments such as:
> > /* -- The following code's added by MPlayer --------------------------------*/
> >
> > The problem once again is that we don't already have such a file, so
> > if you diff official code with our code, it will likely be full of
> > cosmetics....
> >
> > Other than that, I had a quick look at your patch, and there are some
> > areas that could be improved I think.
> >
> > For instance:
> >
> > +#if 0
> > +#ifndef _WIN32
> > +        mp_msg(MSGT_VOBSUB, MSGL_DBG2, "UnRAR: Cannot load
> > "LIBUNRAR_NAME": %s\n", dlerror());
> > +#else
> > +        mp_msg(
> > +               MSGT_VOBSUB,
> > +               MSGL_DBG2,
> > +               "UnRAR: Cannot load "LIBUNRAR_NAME", GetLastError()
> > returns %d\n",
> > +               GetLastError());
> > +#endif /* _WIN32 */
> > +#endif
> >
> > Is there a reason to keep #if 0 code?
> >
>
> I don't know if showing warning messages is acceptable here in
> unrar.c, since the original file did only the decompressing thing
> without interfering with other parts of mplayer....

Don't know. As long as you're not generating a shitload of warnings,
and that these warnings are only printed in verbose mode, I don't
mind.

Guillaume

-- 
"Success consists of going from failure to failure without loss of enthusiasm."
 -- Winston Churchill