[MPlayer-dev-eng] patch for vol level

Uoti Urpala uoti.urpala at pp1.inet.fi
Sat Jul 29 18:35:05 CEST 2006


On Sat, 2006-07-29 at 17:52 +0200, Guillaume POIRIER wrote:
> > This patch restores back the volume to its previous level before quitting
> > mplayer when the vol was muted.

> While I do understand why someone may find this new behavior nice, I 
> don't personally expect any sound application to behave as such.
> Sorry, but don't think I'll apply your patch.

I think global volume should not be left muted after exiting. However it
is not quite as easy to do correctly as this patch.

MPlayer may exit the main loop after all audio has been fed to the ao
but not been played. audio_out->uninit() is then called with a flag that
tells the ao to finish playing current audio and then do the uninit. So
unmute cannot be done before audio_out->uninit() because uninit() may
still be used to play more audio. Unmute shouldn't be done after
uninit() either because mute depends on ao functions. Proper
implementation would require changing the ao functions.




More information about the MPlayer-dev-eng mailing list