[MPlayer-dev-eng] [PATCH] - fix for audio and video in dvr-ms asf

[John Donaghy]

Hi

The patch I submitted to enable mplayer to play dvr-ms files was
eventually committed some time ago after a lengthy review process.
Unfortunately, however, a rather important line of code was removed
during the review that has the effect of making the audio stream
undetectable.

> I can't see any obvious problems with this patch, though I didn't check
> too much. Just one thing:
>
> On Sat, Apr 29, 2006 at 05:45:44PM -0500, John Donaghy wrote:
> > +  pos=0;
> > +  if ((pos = find_asf_guid(hdr, asf_ext_stream_audio, pos, hdr_len)) >= 0)
> > +  {
>
> This pos=0 line is pointless, get rid of it.
>

It turns out that this line of code is not pointless but in fact
essential because otherwise the pos variable is used before it is
initialised. At the time, I resubmitted the patch without the line in
question based on Reimar's comment, and I assume that I checked that
it worked at the time. Perhaps the uninitialised variable just
happened to contain zero at the time I tested it. (I was certainly
bored with the process by this point so I didn't think too hard about
it!)

Anyway, I'm requesting that this "pos=0" line be added back into
asf_header,line 233. Should I submit a patch or is the information
I've provided here enough to enable the change to be made?

Regards,

John Donaghy

> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
>