[MPlayer-dev-eng] [PATCH] - fix for audio and video in dvr-ms asf

Uoti Urpala uoti.urpala at pp1.inet.fi
Tue Jul 18 00:19:28 CEST 2006


On Mon, 2006-07-17 at 16:45 -0500, John Donaghy wrote:
> > This pos=0 line is pointless, get rid of it.
> >
> 
> It turns out that this line of code is not pointless but in fact
> essential because otherwise the pos variable is used before it is
> initialised. At the time, I resubmitted the patch without the line in
> question based on Reimar's comment, and I assume that I checked that
> it worked at the time. Perhaps the uninitialised variable just
> happened to contain zero at the time I tested it. (I was certainly
> bored with the process by this point so I didn't think too hard about
> it!)
> 
> Anyway, I'm requesting that this "pos=0" line be added back into
> asf_header,line 233. Should I submit a patch or is the information
> I've provided here enough to enable the change to be made?

I'll change the function call to use 0 as the parameter instead of pos.




More information about the MPlayer-dev-eng mailing list