[MPlayer-dev-eng] [PATCH] matroska chapter seeking

[Nico Sabbi]

Evgeniy Stepanov wrote:

>On Saturday 15 July 2006 21:21, Nico Sabbi wrote:
>  
>
>>>+  demuxer->chapters = mkv_d->chapters;
>>>+  demuxer->num_chapters = mkv_d->num_chapters;
>>>+
>>>      
>>>
>>I really don't like those two lines; instead you should memcpy (or
>>assign directly to demuxer)
>>the chapters structure
>>    
>>
>
>Agreed, no point in keeping chapters in mkv_d. Moved to demuxer.
>
>  
>
>>You totally missed the uninit part of demuxer->chapters :)
>>    
>>
>
>It was not needed since only the pointer was copied to demuxer.
>
>Man page updated.
>  
>
>------------------------------------------------------------------------
>

looks nice to me