[MPlayer-dev-eng] [PATCH] matroska chapter seeking

[Evgeniy Stepanov]

On Saturday 15 July 2006 21:21, Nico Sabbi wrote:
> >+  demuxer->chapters = mkv_d->chapters;
> >+  demuxer->num_chapters = mkv_d->num_chapters;
> >+
>
> I really don't like those two lines; instead you should memcpy (or
> assign directly to demuxer)
> the chapters structure

Agreed, no point in keeping chapters in mkv_d. Moved to demuxer.

> You totally missed the uninit part of demuxer->chapters :)

It was not needed since only the pointer was copied to demuxer.

Man page updated.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: seek_chapter.patch
Type: text/x-diff
Size: 12630 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060715/0815e783/attachment.patch>