[MPlayer-dev-eng] [PATCH] Remove #if LIBAV*_BUILD >= XXXX everywhere

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Jul 12 08:41:13 CEST 2006


Hello,
On Wed, Jul 12, 2006 at 12:50:17AM +0200, Diego Biurrun wrote:
> All the code that interfaces with FFmpeg is littered with
> 
> #if LIBAVFORMAT_BUILD >= 4624
> 
> and similar statements.  While this may have made sense in the past when
> lavc/lavf was not checked out as external, it just clutters the sources
> now IMO.

I fully agree and never understood the point of it, since MPlayer
wouldn't really work with old versions anyway, it would just break in
more obscure ways which I don't consider helpful.

>  5 files changed, 8 insertions(+), 325 deletions(-)

If and all those 8 insertions seem to come from trailing whitespace
removal, if I was nit-pickish I'd say they don't belong in this patch :-P

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list