[MPlayer-dev-eng] [PATCH] Remove #if LIBAV*_BUILD >= XXXX everywhere

[Michael Niedermayer]

Hi

On Wed, Jul 12, 2006 at 12:50:17AM +0200, Diego Biurrun wrote:
> It's a jungle out there!
> 
> All the code that interfaces with FFmpeg is littered with
> 
> #if LIBAVFORMAT_BUILD >= 4624
> 
> and similar statements.  While this may have made sense in the past when
> lavc/lavf was not checked out as external, it just clutters the sources
> now IMO.
> 
> This may make sense for shared lavc/lavf (which is discouraged anyway),
> but even then we could just #error out below a certain version number
> instead of disabling some features.  To the outside world the disabling
> will most probably appear random anyway.
> 
> I propose ripping it all out, patch is attached.
> 
> In any case, the diffstat summary is quite convincing IMO:
> 
>  5 files changed, 8 insertions(+), 325 deletions(-)
> 
> Did I overlook something?  Michael, OK to commit?

not without hearing a comment from who originally wanted these checks
(IIRC it was arpi)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is