[MPlayer-dev-eng] [PATCH]Potential crash with realmedia files

[Roberto Togni]

On Tue, 11 Jul 2006 20:35:29 +0800
陆然 <hephooey at gmail.com> wrote:

> Hi,
> 
> demux_real_fill_buffer() set demuxer->stream->eof =1 when it found an INDX 
> chunk in rm files, and return 0. But when this function was called by audio 
> decoding functions, the main loop does not end. The buffer will still try to 
> read data from the INDX chunk again and again. Sometimes we are lucky the 
> last fill_buffer call is from the video decoding and mplayer quit 
> successfully, but this is not true with every files.
> 
> here is a almost trivial patch to fix this, if demuxer->stream->eof == 1, then 
> never try to fill the buffer anymore.
> 

It may help, but I'm not convinced that this is the right solution (i
have at least one sample that doesn't work with this).

Can you try the attached patch? It changes the audio decoder so that it
does not ignore an EOF from the demuxer.

Ciao,
 Roberto
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ad_realaud.c.diff
Type: text/x-patch
Size: 489 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060711/f02fb3c1/attachment.bin>