[MPlayer-dev-eng] Patch for use of SDL(audio/video) on AmigaOS4 - Try #2

[Guillaume Poirier]

Hi,

Andrea Palmatè wrote:
> DOH..
> ---------------------------
> A new try to commit a patch that:
> 
> * Change ao_sdl.c to use the correct buffer under AMIGAOS4

This part seems Ok to me.


> * Change vo_sdl.c to implement correctly the SDL under AMIGAOS4.
>     It add os4video as SDL driver

This on, I'm not so sure...

> @@ -446,7 +446,7 @@
>  		//}	
>  	#endif	
>  
> -#ifndef AMIGA
> +#ifndef __AMIGAOS4__


Won't this remove support for versions of AmigaOS earlier than 4?
Also, I bet __AMIGAOS4__ is a symbol provided by GCC or GNU toolchain,
not by MPlayer's configure.
I _guess_ the right fix is to correct our configure script so that it
defines the AMIGA symbol on Amiga platform.


>  	priv->sdlfullflags |= SDL_DOUBLEBUF;	
>  	if (vo_doublebuffering)
>  	    priv->sdlflags |= SDL_DOUBLEBUF;
> @@ -891,6 +891,7 @@
>  		||(strcmp(priv->driver, "directx") == 0)
>  		||(strcmp(priv->driver, "Quartz") == 0)
>  		||(strcmp(priv->driver, "cgx") == 0)
> +		||(strcmp(priv->driver, "os4video") == 0)

Seems alright.

Guillaume