[MPlayer-dev-eng] Patch for use of SDL(audio/video) on AmigaOS4

Diego Biurrun diego at biurrun.de
Mon Jul 10 16:41:04 CEST 2006


On Mon, Jul 10, 2006 at 03:11:07PM +0200, Andrea Palmatè wrote:
> At 14:45 10/07/2006 +0200, you wrote:
> >Your patch is full of cosmetics(*) and is therefore rejected in its
> >current form. Please resent a clean version.
> >
> >Also, it would be good if you could explain what this patch is meant
> >to change, such as:
> >- fix some bugs
> >- add new arch supported through SDL
> >- support latest version of SDL...
> >- etc...
> >
> >Guillaume
> >(*) cosmetics are non-functionnal changes such as white space
> >removal/addition, indentation, etc...
> Ok. but i've only used the command
> 
> svn diff >patch_name
> 
> to create the patch automatically with svn. What's wrong?

The problem are the changes you made and that you apparently did not
check the patch after creating it...

Diego



More information about the MPlayer-dev-eng mailing list