[MPlayer-dev-eng] [PATCH] GTK2 support

[Torinthiel]

On Mon, Feb 20, 2006 at 06:39:24PM -0500, Rich Felker wrote:
> 
> On Mon, Feb 20, 2006 at 11:08:57PM +0100, Torinthiel wrote:
> > On Mon, Feb 20, 2006 at 11:01:38AM +0100, Adam Tla/lka wrote:
> > > It is is the correct way and of course all messagess should be in UTF-8
> > > format or must have information about encoding included so iconv function
> > > can recode text to the desired encoding depending of output mode -
> > > terminal or gtk internal representation.
> > 
> > More or less they have that information - stored in help/*.charset
> > files. It's not easily available during runtime though. But there's the
> > --charset option to ./configure if one needs it. And I oppose
> > hard-coding utf-8 by default, as it breaks any non-english non-utf8
> > messages, which are working perfectly now.
> 
> It doesn't. They will be conveted just fine with iconv.

If it will then I'm for it. I've just tested (barely) Reimar's patch,
and it seems to be working for me (console only) (./configure with
--enable-gui, which I don't use but is in my default config for some
time). Having tested without --enable-gui as well, it works (still only
console though).

> > Unless someone comes with a way to do it correctly, i.e. making gtk1,
> > gtk2, utf-8 consoles and non-utf consoles working. The gettext might be
> > a way. There is code to convert .h files to gettext's .po files, I'll
> > send it on request, all that is left is integrating it into configure.
> 
> I oppose using gettext. It's bloated and catgets (the standard POSIX
> message catalog system as opposed to the GNU replacement) fits much
> better with MPlayer's existing model of using #defines for the
> messages. Look up catgets and see how it works.

I'll try, although a pointer to the doc's could be useful. Only thing
now I know about catgets is what was in gettext's manual. I agree that
it suits MPlayer's model better then gettext, and I think it will be
quite simple to convert to catgets, but having in mind that catgets
might not be available (as well as gettext ;)
And yes, gettext is bloated. I only proposed it because most of the work
is already done (but most of that could be reused).
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3073512
   torinthiel(at)megapolis(dot)pl
   gpg: 0906A2CE fpr: EE3E DFB4 C4D6 E22E 8999  D714 7CEB CDDC 0906 A2CE
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060221/dcf7d6d4/attachment.pgp>