[MPlayer-dev-eng] [PATCH] GTK2 support

[Rich Felker]

On Mon, Feb 20, 2006 at 11:08:57PM +0100, Torinthiel wrote:
> On Mon, Feb 20, 2006 at 11:01:38AM +0100, Adam Tla/lka wrote:
> > It is is the correct way and of course all messagess should be in UTF-8
> > format or must have information about encoding included so iconv function
> > can recode text to the desired encoding depending of output mode -
> > terminal or gtk internal representation.
> 
> More or less they have that information - stored in help/*.charset
> files. It's not easily available during runtime though. But there's the
> --charset option to ./configure if one needs it. And I oppose
> hard-coding utf-8 by default, as it breaks any non-english non-utf8
> messages, which are working perfectly now.

It doesn't. They will be conveted just fine with iconv.

> Unless someone comes with a way to do it correctly, i.e. making gtk1,
> gtk2, utf-8 consoles and non-utf consoles working. The gettext might be
> a way. There is code to convert .h files to gettext's .po files, I'll
> send it on request, all that is left is integrating it into configure.

I oppose using gettext. It's bloated and catgets (the standard POSIX
message catalog system as opposed to the GNU replacement) fits much
better with MPlayer's existing model of using #defines for the
messages. Look up catgets and see how it works.

Rich