[MPlayer-dev-eng] [PATCH] ve_lavc cosmetics: empire strikes back

Robert Swain robert.swain at gmail.com
Sun Feb 19 02:06:01 CET 2006


Hey,

I would have continued the other thread but I don't have those e-mails in my 
client anymore so...

In the mists of time (2006-02-12 17:35:57 GMT) someone (Michael Niedermayer 
<michaelni <at> gmx.at>) said:
>i agree with 
>* 4space indention
>* trailing whitespace removial
>* tab removial
>* i agree with moving "{" which are on their own line

>i do not agree with
>* x=y / x = y changes
>* breaking lines > 80 columns
>* removing {} of if/for if theres just one statement inside
>* reindenting lavcopts_conf table, this serves no purpose

I disagree with the last point as there is a mix of tabs and spaces, and the 
space indentation is also messed up. See the patches.

Ta ta,
Rob :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer.ve_lavc.cosmetics.2.diff
Type: text/x-diff
Size: 46968 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060219/eaa50cbb/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer.ve_lavc.cosmetics.2-uBw.diff
Type: text/x-diff
Size: 5363 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060219/eaa50cbb/attachment-0001.diff>


More information about the MPlayer-dev-eng mailing list