[MPlayer-dev-eng] altivec patch 1/5: missing vec_splat in vec_clip

Romain Dolbeau romain at dolbeau.org
Thu Feb 9 09:49:23 CET 2006


Luca Barbato wrote:

> Ugly but working macro, please benchmark it against load&splat.

Yuck. This seems to me completely unacceptable, as
it makes for unportable, unreadable, likely-to-be-faulty,
possibly future-unproof code, that additionaly won't
compile with anything but a handful of gccs (and yes,
xlc can be used on most if not all of the altivec code
once you take out the gcc-only includes).

If the non-splated macro works on the original, reference
implementation of the AltiVec intrinsics (i.e. the
Apple/motorola [before they became freescale] gcc),
then that should be the actual implementation, with
#define'd, documented workaround for the others, broken
gcc out there.

-- 
Romain Dolbeau
<romain at dolbeau.org>




More information about the MPlayer-dev-eng mailing list