[PATCH] Re: [MPlayer-dev-eng] MSGTR messages for vid/aid in non-verbose output?

[mail at kraymer.de]

> On 4 Dec 2006 11:54, Diego Biurrun wrote:
>> [...]
>
> I've adapt them, sorry for delay. Also I adapted dvd's demuxing in
> stream/stream_dvd.c as Sebasian earlier suggested. But such kind
> of changes takes a price: there are two informational lines about
> track for these formats, not one; e.g.:
> ---
> [demux] Subtitle stream detected, -sid 0
> [mkv] Track ID 4: subtitles (S_TEXT/SSA), -slang eng
> ---
> instead of
> ---
> [mkv] Track ID 4: subtitles (S_TEXT/SSA), -sid 0, -slang eng

IMO that isn't really a problem..

>> > Well, patch attached. The second one is russian translation
>> > for new messages.
>>
>> You can leave out the Russian translation for now, this will be
>> taken care of later.
>
> ok

..and still you did it again ;)
My guess is that you did it to prevent compiling issues. It's fine with me
since some translations are unmaintained and would not be usable at all if
nobody fixes them.
> I separate changes into two paches:
>
> 1st) Add general info in demuxer.c and change behavior for ogg and  mkv
> demuxers + update help_mp-en.h for new demuxer messages.
> Patch was tested for both *.ogm and *.mkv as well as for ordinary  avis
> (all files with multiple streams, of course).

Appears to work here (tested with mkv only since all my oggs are single
audio only), giving the output you described above.
> 2nd) Change behavior of dvd stream demuxer, this requieres changes  in
> help_mp* files since number of mp_msg arguments was changed.
> Thus I separate this patch. Also it figured out that I have no
> plain dvds (all was converted to mpeg4/x264) so I can't test dvd
> stream demuxer output behavior. Should work fine, but please, test
> with some dvds.

I noticed a problem with that. Detection and displaying language tracks
gets mixed up, for my test dvd it was:
Audio-Stream: 0 Format: ac3 (5.1) Sprache: en.
Audio-Stream: 1 Format: dts (5.1) Sprache: en.
Anzahl der Audiokanäle auf der Disc: 2.
[..]
[demux] Video stream detected, -vid 0
[demux] Audio stream detected, -aid 137
[demux] Audio stream detected, -aid 128

(it's part German but you'll get the meaning)
Problem is, audio stream 0 does not match -aid 137. mplayer -aid 128 plays
the ac3 stream, which is correct, according to demuxer init and lsdvd:
Title: 01, blabla
        Audio: 1, Language: en - English, Format: ac3, ... Stream id: 0x80
        Audio: 2, Language: en - English, Format: dts, ... Stream id: 0x89

I didn't dig the source so I don't know if only the order is wrong or if
the issue goes deeper. Maybe it's something you changed?
Hope that helps,


Sebastian