[PATCH] Re: [MPlayer-dev-eng] MSGTR messages for vid/aid in non-verbose output?

[Andrew Savchenko]

On 4 Dec 2006 11:54, Diego Biurrun wrote:
> On Sun, Dec 03, 2006 at 05:56:25PM +0300, Andrew Savchenko wrote:
> > On 2 Dec 2006 23:44, Diego Biurrun wrote:
> > > On Tue, Nov 21, 2006 at 03:03:53PM +0300, Andrew Savchenko 
wrote:
> > So my suggestion is to add appropriate messages directly into
> > demuxer.c, so they will be uniform despite of the demuxer
> > type. IMHO this will be usefull to user. OTOH this may make an
> > overhead of usefull information in the cases when format's
> > dexuxer provides this information also (such as demux_ogg and
> > demux_mkv). Therefore must be some check for demuxer type in
> > order to realize necessity of such message. I made this check
> > to skip printing message in the case of ogg or mkv demuxer.
>
> The patch seems OK for a first draft, but the special-casing for
> Ogg and Matroska is ugly.  Possibly those two demuxers need to
> be adapted.

I've adapt them, sorry for delay. Also I adapted dvd's demuxing in 
stream/stream_dvd.c as Sebasian earlier suggested. But such kind 
of changes takes a price: there are two informational lines about 
track for these formats, not one; e.g.:
---
[demux] Subtitle stream detected, -sid 0
[mkv] Track ID 4: subtitles (S_TEXT/SSA), -slang eng
---
instead of
---
[mkv] Track ID 4: subtitles (S_TEXT/SSA), -sid 0, -slang eng
---

> > Well, patch attached. The second one is russian translation
> > for new messages.
>
> You can leave out the Russian translation for now, this will be
> taken care of later.

ok

I separate changes into two paches:

1st) Add general info in demuxer.c and change behavior for ogg and 
mkv demuxers + update help_mp-en.h for new demuxer messages.
Patch was tested for both *.ogm and *.mkv as well as for ordinary 
avis (all files with multiple streams, of course).

2nd) Change behavior of dvd stream demuxer, this requieres changes 
in help_mp* files since number of mp_msg arguments was changed.
Thus I separate this patch. Also it figured out that I have no 
plain dvds (all was converted to mpeg4/x264) so I can't test dvd 
stream demuxer output behavior. Should work fine, but please, test 
with some dvds.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061211/b888d8fd/attachment.pgp>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: demuxer.patch
Type: text/x-diff
Size: 9236 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061211/b888d8fd/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stream_dvd.patch
Type: text/x-diff
Size: 13632 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061211/b888d8fd/attachment-0001.patch>