[MPlayer-dev-eng] [PATCH] Make all subtitles availiable

[Guillaume POIRIER]

Hi,

On 12/10/06, Lehel Bernadt <lehel at pmc-services.hu> wrote:
>
> Hello all!
>
> On Monday 04 December 2006 23:51, Guillaume POIRIER wrote:
> > >
> > > It might affect the correct working of frontends.
> > > Nevertheless in this case I agree it is a different issue not directly
> > > related to this, so I don't have any further objections to the patch.
> > > Would be nice to see those ID_SUBTITLE_ID messages "fixed" (according to
> > > what I consider correct) anyway though.
> >
> > Ok, very nice to hear; Lehel, fire up your mencoder patch, I'll test
> > it and hopefully commit both patches (as I said earlier, mencoder and
> > mplayer need to behave the same so that dumping vobsubs works in a
> > deterministic way).
>
> Finally i had the time to deal with this... so here are 2 patches, one for
> fixing the subtitle selection in both mplayer.c and mencoder.c, and the other
> correcting the identify output to be consistent with the sid numbers as
> suggested by Reimar.

I've just tested your first patch, and it seems to work on the 2
broken DVDs I have. I'll keep it in my local tree for more testing,
unless Reimar blesses that patch, off course.

Thanks!

Guillaume
-- 
An association of men who will not quarrel with one another is a thing
which has never yet existed, from the greatest confederacy of nations
down to a town meeting or a vestry.
 -- Thomas Jefferson
(when interviewed about MPlayer ML flamewars)
http://www.brainyquote.com/quotes/quotes/t/thomasjeff157207.html