[MPlayer-dev-eng] [PATCH] Make all subtitles availiable

[Lehel Bernadt]

Hi,

On Sunday 10 December 2006 17:07, Nico Sabbi wrote:
> >>
> >>Are you sure it is correct that once it is d_dvdsub->id and once
> >>dvdsub_id that gets the spu id? That seems likely to break embedded
> >>subtitles...
> >
> > Well theoretically dvdsub_id should get the spu id in mplayer.c as
> > well... but that would seriously break things, since dvdsub_id is also
> > used as an index into the set_of_subtitles array. That's why i left it
> > with the sid value, and fortunately it's not used in any other way,
> > because its value is assigned to d_dvdsub->id before the sub display. And
> > that's where my patch comes in.
> >
> > Now in mencoder.c, this assignment is not done, so i had to change
> > dvdsub_id itself, but here this change poses no problem. And d_dvdsub->id
> > is not used in mencoder.c at all.
> >
> > So basically two different executables, two different approaches. I know
> > it's a bit confusing, but i think for a more consistent code a redesign
> > of the subtitle system would be needed.
> >
> > Best wishes,
> > Lehel
>
> this patch is very very hackish.

It might be, but
a) it's only 2 lines of code
b) it really works, without side effects

> This whole confusion on the dvdsub streams leads me to believe that
> the introduction of the global_sub stuff in mplayer made things worse
> rather than better

Well i'm not the one to judge that... my aim was to fix things without 
stirring up the code too much, since i don't have much overview of the 
mplayer architecture.
So basically you have 4 options:
1. leave things as they are, with broken sub selection
2. rewrite the sub handling logic from a clean sheet
3. apply this patch
4. try to experiment with some nicer fixes in hope that they will work
The choice is yours :)

Lehel