[MPlayer-dev-eng] [PATCH] Get rid of -D_GNU_SOURCE

[Reimar Döffinger]

Hello,
On Fri, Dec 08, 2006 at 02:35:19PM +0100, Diego Biurrun wrote:
> On Fri, Dec 08, 2006 at 10:15:30AM +0100, Reimar Doeffinger wrote:
> > --- libdvdcss/Makefile	(revision 21535)
> > +++ libdvdcss/Makefile	(working copy)
> > @@ -9,7 +9,7 @@
> >  
> > -CFLAGS= -D__USE_UNIX98 -D_GNU_SOURCE \
> > +CFLAGS= -D__USE_UNIX98 \
> >  	-DHAVE_LIMITS_H -DHAVE_ERRNO_H -DHAVE_INTTYPES_H -DHAVE_UNISTD_H \
> >  	-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DVERSION=\"1.2.9\"
> 
> .. for external libraries I'm not so sure.  If they are compiled with
> _GNU_SOURCE upstream then I think we should use the same configuration.

Well, are they? Since the Makefile is created by us it might easily go
out of sync. Also, IMO it does not hurt if we detect gnuishms in
external code, too, might be helpful in fixing compilation problems that
we would otherwise not be able to reproduce.
Nevertheless, I don't mind not changing that, I just wanted to propose a
complete patch.
Anyone else having an opinion?

Greetings,
Reimar Döffinger