[MPlayer-dev-eng] [PATCH] Get rid of -D_GNU_SOURCE

[Diego Biurrun]

On Fri, Dec 08, 2006 at 10:15:30AM +0100, Reimar Doeffinger wrote:
> it seems to be unneeded, so this patch removes it. sdl-config once again
> is again a prime example why it is not a good idea to trust such scripts that
> create cflags/ldflags for you, given the amount of hacks we need
> currently to use it, not using it might even be the less complex
> approach...

I think I'm generally in favor of this, but ..

> --- libfaad2/Makefile	(revision 21535)
> +++ libfaad2/Makefile	(working copy)
> @@ -42,8 +42,6 @@
>  
> -CFLAGS  = -D_GNU_SOURCE
> -
> --- dvdread/Makefile	(revision 21535)
> +++ dvdread/Makefile	(working copy)
> @@ -11,7 +11,7 @@
>  
> -CFLAGS= -D__USE_UNIX98 -D_GNU_SOURCE -DSTDC_HEADERS \
> +CFLAGS= -D__USE_UNIX98 -DSTDC_HEADERS \
>  	-DHAVE_LIMITS_H -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
>  
> --- libdvdcss/Makefile	(revision 21535)
> +++ libdvdcss/Makefile	(working copy)
> @@ -9,7 +9,7 @@
>  
> -CFLAGS= -D__USE_UNIX98 -D_GNU_SOURCE \
> +CFLAGS= -D__USE_UNIX98 \
>  	-DHAVE_LIMITS_H -DHAVE_ERRNO_H -DHAVE_INTTYPES_H -DHAVE_UNISTD_H \
>  	-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DVERSION=\"1.2.9\"

.. for external libraries I'm not so sure.  If they are compiled with
_GNU_SOURCE upstream then I think we should use the same configuration.

Diego