[MPlayer-dev-eng] [PATCH] Message translation
Ötvös Attila
oattila at chello.hu
Mon Dec 4 18:16:22 CET 2006
hétfő 04 december 2006 11:23 dátummal Diego Biurrun ezt írta:
Hi Diego Biurrun!
> Why are you sending this tarball?
"9. [...] Do not compress your patch unless it is larger than 80k or if
you know that your mailer messes up (reformats) text attachments."
The patch size ~112k.
> Why not a single patch?
I remember somebody wrote me that I cut the patch becouse all-in-one
it can difficulty be read.
> You just seem to have cut your patch apart directory by
> directory. This is senseless and greatly reduces your chances of
> getting somebody to review and maybe test your patches.
Torinthiel wrote:
"Splitting patches is good. Oversplitting is bad."
So I grouped the patch as directories.
I get balled up :(.
How shall I proceed to be right my patch?
Thanks in advance your help.
Attila
More information about the MPlayer-dev-eng
mailing list