[MPlayer-dev-eng] [PATCH] Message translation

[Diego Biurrun]

On Mon, Dec 04, 2006 at 10:50:41AM +0100, Ötvös Attila wrote:
> hétfő 04 december 2006 09:31 dátummal Diego Biurrun ezt írta:
> > How did you manage to create such a broken patch?  It reverts several of
> > the last commits to our tree.  Something is very broken in the way you
> > create patches.  May I suggest that you read
> I sorry!
> 
> 1. Create patch from edited source (20061129)
> 2. Download new source from svn
> 3. Apply patch and if required manual modify (20061204)
> 4. Create patch from patched source
> 5. Test patch apply.
> 
> I don't modify patch creator script (edited source path (20061129) -> patched 
> source path (20061204) and now I don't test patch apply.
> 
> I again sorry!

Can you please read

http://www.mplayerhq.hu/DOCS/tech/patches.txt

again?

Why are you sending this tarball?  Why not a single patch?  Patches
should be as small as possible, but no smaller.  This means that they
should be self-contained.  MPlayer should still work and compile after
applying them.  You just seem to have cut your patch apart directory by
directory.  This is senseless and greatly reduces your chances of
getting somebody to review and maybe test your patches.

Diego