[MPlayer-dev-eng] [PATCH] Make all subtitles availiable

[Lehel Bernadt]

On Monday 04 December 2006 10:10, Reimar Doeffinger wrote:
> Hello,
>
> On Mon, Dec 04, 2006 at 09:53:57AM +0100, Guillaume Poirier wrote:
> > Lehel Bernadt wrote:
> > > Hello,
> > >
> > > On Sunday 03 December 2006 21:38, Guillaume POIRIER wrote:
> > >>I've just tested your patch on a DVD that was problematic (LOTR 2
> > >>Towers, long ed.) and it works fine.
> > >>I haven't tried with your patch + Nico's suggested fix yet though.
> > >
> > > There's no need to do that, my patch should be enough (it doesn't deal
> > > with the function Nico was having his observation about, cause that
> > > doesn't need to be patched anyway).
> >
> > Ah, Ok. :)
> >
> > Again, this patch works well for me and I'm willing to apply it... but
> > I won't because mencoder.c needs to be patched too so that it is also
> > able to access all subs.
>
> I think that patch will not fit the mismatches between the ID_ and
> "normal" output concerning the sid numbers, so there still is something
> broken.

You think? Why don't you try it instead? ;)

The subtitle mapping fix was my patch too, so let me explain why it will work. 
The ID_SUBTITLE_ID is an spu stream id, that is, the id of a subpicture unit 
stream containing subtitles. The sid number is the number of a specific 
subtitle in the dvd submapping table that consists of 
[sid/slang -> spu1/spu2/spu3/spu4] 
entries. Which spu id out of the 4 is the "real" one? It depends on the video 
format (4:3, 16:9 lbox, 16:9 wide, 4:3 panscan). In the end, one spu id is 
selected for the specific sid. So it's normal that there is a mismatch, since 
sids are incremental numbers from 0 to nr_of_subs-1, while spu ids are 
whatever numbers they have in the MPEG-PS stream.
Point is, the only thing that matters is that the right spu stream is selected 
for the corresponding sid/slang, and my patch does exactly that.

I'll look at mencoder.c in the evening.

Regards,
Lehel