[MPlayer-dev-eng] [PATCH] Make all subtitles availiable

Guillaume POIRIER poirierg at gmail.com
Mon Dec 4 10:35:34 CET 2006


Hi,

On 12/4/06, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hello,
> On Mon, Dec 04, 2006 at 09:53:57AM +0100, Guillaume Poirier wrote:
> > Lehel Bernadt wrote:
> > > Hello,
> > >
> > > On Sunday 03 December 2006 21:38, Guillaume POIRIER wrote:
> > >
> > >>I've just tested your patch on a DVD that was problematic (LOTR 2
> > >>Towers, long ed.) and it works fine.
> > >>I haven't tried with your patch + Nico's suggested fix yet though.
> > >
> > >
> > > There's no need to do that, my patch should be enough (it doesn't deal with
> > > the function Nico was having his observation about, cause that doesn't need
> > > to be patched anyway).
> >
> > Ah, Ok. :)
> >
> > Again, this patch works well for me and I'm willing to apply it... but
> > I won't because mencoder.c needs to be patched too so that it is also
> > able to access all subs.
>
> I think that patch will not fit the mismatches between the ID_ and
> "normal" output concerning the sid numbers, so there still is something
> broken.

This means it will break -slang option ? That can't be good.

Well, current situation sucks too. VLC is able to list all subs (but
part of them don't have any language ID associated to them), and
allows to switch between all of them, so there must be a way to do
this... :-(

Guillaume
-- 
An association of men who will not quarrel with one another is a thing
which has never yet existed, from the greatest confederacy of nations
down to a town meeting or a vestry.
 -- Thomas Jefferson
(when interviewed about MPlayer ML flamewars)
http://www.brainyquote.com/quotes/quotes/t/thomasjeff157207.html



More information about the MPlayer-dev-eng mailing list