[MPlayer-dev-eng] [PATCH] ASS subtitle speedup (take 2)

[Reimar Döffinger]

Hello,
On Sat, Dec 02, 2006 at 10:59:31PM +0300, Evgeniy Stepanov wrote:
> On Saturday 02 December 2006 22:33, Reimar Döffinger wrote:
> > > > Though I wonder if/how the imgs->imgs == NULL && imgs->changed == 1
> > > > case should be handled (your code probably would crash?).
> > >
> > > Why should it ? imgs->imgs == NULL is nothing special, just a list of
> > > zero elements.
> >
> > Because the original patch did
> > goto skip_upload;
> > without checking img!=NULL and the code at skip_upload did assume it to be
> > != NULL IIRC.
> 
> I still don't see how it depends on that, but ok, extra check won't hurt. A 
> new version fixing everything that was discussed.

No obvious problems (also had a quick look at the other code).

> +  ass_image_t *img;
>    ass_image_t *i;
>    int cnt;
> +
> +  img = imgs->imgs;

Move the initialization up to the declaration before committing (no need
to send a new patch because of this of course).

Greetings,
Reimar Döffinger