[MPlayer-dev-eng] [PATCH] ASS subtitle speedup (take 2)

Evgeniy Stepanov eugeni.stepanov at gmail.com
Sat Dec 2 20:59:31 CET 2006


On Saturday 02 December 2006 22:33, Reimar Döffinger wrote:
> > > Though I wonder if/how the imgs->imgs == NULL && imgs->changed == 1
> > > case should be handled (your code probably would crash?).
> >
> > Why should it ? imgs->imgs == NULL is nothing special, just a list of
> > zero elements.
>
> Because the original patch did
> goto skip_upload;
> without checking img!=NULL and the code at skip_upload did assume it to be
> != NULL IIRC.

I still don't see how it depends on that, but ok, extra check won't hurt. A 
new version fixing everything that was discussed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ass-speed3.patch
Type: text/x-diff
Size: 7947 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061202/8a82cab7/attachment.patch>


More information about the MPlayer-dev-eng mailing list