[MPlayer-dev-eng] [PATCH] further dvr-ms playback improvements

[Nico Sabbi]

John Donaghy wrote:

>> > So, just to clarify, the framerate belongs in the demuxer but the
>> > framesize and bitrate dont?
>>
>> exactly
>>
> So you would accept the patch including the mpeg header parsing if it
> only attempted to set the framerate?


no, that code is still not part of a demuxer's duties.

There are other possible fixes (but in all cases audio playback is broken)
1) use -correct-pts: video playback is better but still accelerated;
2) use the attached patch: it's much more appropriate and much less 
intrusive,
although there are a lot of things to consider before committing it
(especially the fact that in general the framerate must be set by the 
demuxer,
but demux_asf hardcodes it to 1000 fps); on the other side delegating
this assignment to the decoder can help to fix one of mplayer's limitation:
when playing file formats that don't have a nominal framerate  (such as
asf, mpeg*) video.c tries to parse the video stream headers to set the 
framerate,
an operation that it should _not_ do.

Any good advice?

BTW, that file seems to be somewhat broken: the timestamps delta seem to be
completely random: .8, .108, .26, etc. seconds; what the hell of a program
can have made such a mess?
If the file is not broken then maybe the demuxers we have are pushing 
packets
with wrong timestamps
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asf.diff
Type: text/x-patch
Size: 1583 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060825/1df67697/attachment.bin>