[MPlayer-dev-eng] [PATCH] further dvr-ms playback improvements

[Uoti Urpala]

On Fri, 2006-08-25 at 21:18 +0200, Nico Sabbi wrote:
> There are other possible fixes (but in all cases audio playback is broken)
> 1) use -correct-pts: video playback is better but still accelerated;

What do you mean by "accelerated"? As already noted on IRC the video
playback time matches the total length of 20 s, with or without
-correct-pts. Are you saying the total length value is wrong? And is the
playback really "better" with correct-pts? I don't see much difference.

> 2) use the attached patch: it's much more appropriate and much less 
> intrusive,
> although there are a lot of things to consider before committing it
> (especially the fact that in general the framerate must be set by the 
> demuxer,
> but demux_asf hardcodes it to 1000 fps); on the other side delegating
> this assignment to the decoder can help to fix one of mplayer's limitation:
> when playing file formats that don't have a nominal framerate  (such as
> asf, mpeg*) video.c tries to parse the video stream headers to set the 
> framerate,
> an operation that it should _not_ do.

Is there a reason to believe that it's impossible to get right
timestamps from the demuxer for asf?

> BTW, that file seems to be somewhat broken: the timestamps delta seem to be
> completely random: .8, .108, .26, etc. seconds; what the hell of a program

There was no .8 second frame IIRC, lavf demuxer gave a .008 s one
though.

> can have made such a mess?
> If the file is not broken then maybe the demuxers we have are pushing 
> packets
> with wrong timestamps

Since the MPlayer internal demuxer and lavf give different timestamps at
least one of them is likely broken (both produce weird times for this
file so neither looks obviously worse).