[MPlayer-dev-eng] svn policy change [RFC][PATCH]

[The Wanderer]

Michael Niedermayer wrote:

> Hi
> 
> read patch below
> comments and flames welcome

FWIW, I don't see anything to disagree with about the contents offhand.
My comments are purely of the proofreading type.

> note, i can split it if someone (diego probably) wants

I don't see any particular reason for doing that, offhand...

> -8. Renaming/moving files or contents of files:
> +8. Renaming/moving/copying files or contents of files:
>  
> -  svn move <source> <destination>
> +  svn move <source> <destination>    / svn copy <source> <destination>
>    svn commit <source> <destination>
>  
> -  Do not move or rename files before discussing it on the mplayer-dev-eng
> -  mailing list first!
> +  Do not move or rename files maintained by others then yourself without
> +  discussing it on the mplayer-dev-eng mailing list first!

At a minimum, "than" instead of "then".

I'd be more inclined to say "files of which you are not the maintainer",
but then despite how I may come across in my less coherent moments I'm
used to phrasing things for precision, and that may not sound clear to
J. Random Reader. "files maintained by someone other than yourself" is
another alternative.

You've added "copy" to both the section header and the template command,
but not to this sentence; was that intentional, or did you mean "Do not
move, rename or copy" instead?

> +  Always try to preserve the history and minimize the size of svn diff, dont
> +  copy or move a file by svn delete and svn add, always use svn move or 
> +  svn copy instead

Comma splice after "svn diff".

Missing apostrophe in "don't".

> +  To split a file in 2 use svn copy and remove the lines which are not needed
> +  in both files

I think this should use with "two" instead of "2" - I don't always agree
with that rule when I encounter it in prose, but here the digit trips me
up.

Also, add a comma after the number.

I'd prefer "from each file" instead of "from both files".

> +  You can revert a change by using svn copy from an old revision or by 
> +  reversing the change locally and re-commiting with a proper commit message.
> +  if the change was total nonsense like a policy violation or someone
> +  commiting the wrong file then svn copy is the correct way to reverse

Missing capitalization on "if" at the beginning of the second sentence.

Also, missing comma after "wrong file", and possibly another after
"total nonsense". Together, these would mark the "like a ... wrong file"
block as elidable - you'll notice that "If the change was total
nonsense, then svn copy is the correct way to reverse." is clean by
itself, so commas or parentheses surrounding the intervening block are
appropriate though not absolutely required.

Finally, missing period at the end of the second sentence.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.