[MPlayer-dev-eng] [PATCH] SSA/ASS subtitles support

[Rich Felker]

On Tue, Apr 18, 2006 at 05:04:47AM +0300, Uoti Urpala wrote:
> On Mon, 2006-04-17 at 21:28 -0400, Rich Felker wrote:
> > > The end time for subtitles is when they should disappear already, so the
> > > "(ass_current_timecode <= (event->Start + event->Duration))" test in
> > > render_frame should use "<" instead of "<=".
> > 
> > For floats < and <= might as well be identical I think.. :)
> 
> I noticed it because two subtitles did incorrectly overlap in a few
> places. Those aren't floats but integers in milliseconds. And even if
> those values were kept in floats it almost certainly would still make a
> difference whether it's < or <=.

I assumed ass_current_timecode was a timestamp from the demuxer which
almost surely would not match the low-denominator diadic rationals in
the subtitle file. Anyway if these are integer types, I hope they're
long long...

Rich