[MPlayer-dev-eng] [PATCH] SSA/ASS subtitles support

[Uoti Urpala]

On Mon, 2006-04-17 at 21:28 -0400, Rich Felker wrote:
> > The end time for subtitles is when they should disappear already, so the
> > "(ass_current_timecode <= (event->Start + event->Duration))" test in
> > render_frame should use "<" instead of "<=".
> 
> For floats < and <= might as well be identical I think.. :)

I noticed it because two subtitles did incorrectly overlap in a few
places. Those aren't floats but integers in milliseconds. And even if
those values were kept in floats it almost certainly would still make a
difference whether it's < or <=.

I found another problem with the patch: if PlayResX+Y are missing, the
right defaults (or at least ones matching what Windows video filters
use) are apparently 384/288, not the dimensions of the video.