[MPlayer-dev-eng] [PATCH] win32 gui

[Erik Lunchpail]

> Well, patch looks genereally OK. A merely cosmetic issue, could you
> not 
> use the ugly windows typedefs in mplayer.c? LPCSTR is 'char*', and
> HWND is 
> 'void*'.

No prob, changed.

> Also I don't quite like the invocation of the gui. -slave really does
> have 
> a use, and your patch makes it impossible for ex. to play an audio
> file 
> with keybinds without gui. Is there any way to fake argv[0] in
> windows?...

It's a PITA I know. One option could be to remove the whole
GetCommandLine() check, but the binary would have to be named
gmplayer.exe and started with a .bat file. This way mplayer will by
default NOT use the gui, however there's no argv[0] check against the
.exe exension, so it would have to be called from a .bat file from
within the same directory by omitting the file extension (eg. START
gmplayer) and users could shortcut to the bat file. Does this sound
like a better solution? It would certainly remove part of the mplayer.c
patching.

Regards,
Erik

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com