[MPlayer-dev-eng] [PATCH] win32 gui

[Oded Shimon]

On Sun, Apr 02, 2006 at 01:01:31AM -0500, Erik Lunchpail wrote:
>  
> > Updated to current CVS. The debug console will now show the cpu
> > extensions mplayer was compiled with, and to be consistent, i've
> > changed the "Skin" directory to "skins".
> 
> New patch. Added a new preferences setting to enable/disable using the
> sub window as WinID. Should allow people to still use directx if they
> prefer not to have the sub window using WinID (although it's still
> recommended, especially if using dvd menu's because it tracks dvdnav
> mouse events.)

Well, patch looks genereally OK. A merely cosmetic issue, could you not 
use the ugly windows typedefs in mplayer.c? LPCSTR is 'char*', and HWND is 
'void*'.
Also I don't quite like the invocation of the gui. -slave really does have 
a use, and your patch makes it impossible for ex. to play an audio file 
with keybinds without gui. Is there any way to fake argv[0] in windows?...

- ods15