[MPlayer-dev-eng] [PATCH] SSA/ASS subtitles support

[Evgeniy Stepanov]

On Saturday 01 April 2006 08:23, you wrote:
> Some things I notice on OS X:
>
> * This uses strndup(), which doesn't exist outside glibc.
> * You left a hardcoded freetype path in libmpcodecs/Makefile.

Fixed.

> * Is it really necessary to memcpy every frame in the filter? I'm
> working on removing memcpy from vo_macosx, and I don't want more put
> in the filter chain.

Looks like it is unavoidable.
But it is possible to not copy frames without subtitles, patch attached.

> * Using fontconfig on OS X will be really bad for people who don't
> have X11 installed, since it will have to rescan the system font
> directories every time it starts. There's not really a good solution
> here, though, unless someone wants to write a fontconfig-ATSUI shim.

An option can be added to look only in ~/.mplayer/fonts directory, where all 
embedded fonts go. It is enough in 95% of cases.

> Also, the kerning looks weird on some lines and the letters are all
> very thin compared to Windows' VSFilter or any other player's current
> subtitle handling, but I haven't investigated this very hard.

The border width is probally smaller then in VSFilter. You can try to increase 
it (either in subtitle script, or by adding a multiplier in the 
FT_Stroker_Set call) and see if it becomes better. There is a problem though. 
With some combinations of font size and border width there appears a strange 
gap in some glyph outlines. Maybe a bug in freetype ?

The kerning is a little incorrect because I'm using integer pixel offsets when 
placing glyphs. Subpixel precision leads to poor bitmap cache performance, 
because almost all the glyphs become different. Still, 1/4 or 1/8 pixel 
precision might be acceptable. I'll try it some day.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-ass.patch.bz2
Type: application/x-bzip2
Size: 20651 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060401/2563c4e3/attachment.bin>