[MPlayer-dev-eng] [PATCH] SSA/ASS subtitles support

[Rich Felker]

On Fri, Mar 31, 2006 at 11:23:26PM -0500, Alexander Strange wrote:
> 
> On Mar 31, 2006, at 5:09 PM, Evgeniy Stepanov wrote:
> 
> >Hi
> >
> >Here is an attempt to add ASS rendering capability to mplayer. It is
> >designed as a filter and supports a large part of ASS so-called
> >specification. Reads both external subtitles and the ones embedded in
> >matroska.
> 
> Some things I notice on OS X:
> 
> * This uses strndup(), which doesn't exist outside glibc.

This is very bad. You will get a lot of cola from me for using
glibc-isms. :) Glad it was caught tho.

> * Is it really necessary to memcpy every frame in the filter? I'm  

It should be possible to render the subs along with copying the
picture onto the output buffer, without any extra intermediate copies.
But there's no way to avoid copies altogether. :( You're not allowed
to modify the input buffer.

Rich