[MPlayer-dev-eng] [PATCH] VFCTRL_PAUSE_UPDATE

[Jason Tackaberry]

Hi Reimar,

On Thu, 2005-09-15 at 21:15 +0200, Reimar Döffinger wrote:
> Please try with which vos this happens... Also check how it flickers, is
> it due to the flipping itself, or is it really displaying a black frame
> sometimes?

I tried vo_x11, vo_sdl, and vo_gl2 and it happens with none of those
VOs.  So it could be a bug in vo_xv.  It's definitely not flipping to a
black frame.

> If yes, do the processing and do not pass the control on, since all filters
> thereafter will have gotten the chance to draw in their put_image functions.
> If no, pass the control on.

I reworked this and removed a couple extra global variables.  (Should
make Michael happier :)).  

> When you request the EXPORT type buffer you should set the PRESERVE
> flag, since you might the original data again later. I am not sure if
> this will work out 100%, since the vos do not respect this flag I
> think...

I added MP_IMGFLAG_PRESERVE didn't make any difference to the flickering
problem.

> If you don't get it to work, send the updated patch and I might actually
> try it out *g*

Attached is the updated patch (to work with your VFCTRL updates).  I'd
definitely like to hear about your experiences actually using it. :)

BTW, I'm in #mplayer as Tack, in case you have questions or comments.

Cheers,
Jason.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_overlay-2005-09-15.diff
Type: text/x-patch
Size: 63583 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050915/b08a3386/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: This is a digitally signed message part
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050915/b08a3386/attachment.pgp>