[MPlayer-dev-eng] [PATCH] VFCTRL_PAUSE_UPDATE

[Reimar Döffinger]

Hi,
On Thu, Sep 15, 2005 at 04:02:08PM -0400, Jason Tackaberry wrote:
> Attached is the updated patch (to work with your VFCTRL updates).  I'd
> definitely like to hear about your experiences actually using it. :)

I played around with it and did some modifications, result attached.
Using vo_draw_alpha_yv12 is a bad idea though, unless I finally can
convince everyone to switch to more sane values for the OSD alpha.
But this made me see something else: your blend function uses unsigned
saturate, but the U and V values are actually signed, so for those a
different function using signed saturate should be used.
Also I wonder why in the premultiply_alpha_byte function you aren't
using multiply_alpha...
Some other changes I can still remember:
movl,cmpl->mov, cmp won't compile on 64bit systems otherwise.
lockbyte should be volatile
\n in front of the messages and using perror is not good IMHO.
fix a few includes (esp. missing malloc.h causes crash on 64 bit
systems), compile with -Wall from time to time.
Fix a problem when the timer overflows and use GetTimeMS to reduce the
likelyhood of overflows.
Just have a look at it, I don't have time to clean it up since I'l go on
holiday tomorrow.

Greetings,
Reimar Döffinger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_overlay.c.gz
Type: application/x-gunzip
Size: 9761 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050917/b6dcb970/attachment.bin>