[MPlayer-dev-eng] Re: [PATCH] Auto load vobsub from ~/.mplayer/sub and oss mixer settings "per instance"

[Alban Bedel]

On Thu, 15 Sep 2005 17:19:31 +0200

> Hi,
> On Wed, Aug 31, 2005 at 03:01:02PM +0200, Alban Bedel wrote:
> > I was playing with subtitles autoload and i found out that vobsub in
> > ~/.mplayer/sub are not autoloaded. The first patch fix that.
> 
> Is missing at least a check for psub == NULL.

Right. New patch attached.

> > Another little bugger is ao oss when used with several dsp. One can
> > use -ao oss,oss:/dev/dsp1 to get fallback from one dsp on the other.
> > But then the mixer settings (device and/or channel) are wrong when using
> > the second dsp. So i made a little patch to allow setting mixer device
> > and channel "per instance". The syntax become:
> 
> Nice, but IMHO the whole mixer_channel thing including the global
> option should be removed.

I'm not sure what you mean exactly. Ignore the -mixer-channel option ?
That doesn't sound like a good idea to me.

> Also I think the suboption parser
> should be used (see subopt-helper.h and e.g. vo_gl.c, preinit function
> on how to use it).

Imho it's not worth it considering that all options are strings and
it would break compatibility afaik.

	Albeu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vobsub.patch
Type: application/octet-stream
Size: 1378 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050915/0a404bb3/attachment.obj>