[MPlayer-dev-eng] [PATCH] Auto load vobsub from ~/.mplayer/sub and oss mixer settings "per instance"

Thu Sep 15 17:19:31 CEST 2005

Hi,
On Wed, Aug 31, 2005 at 03:01:02PM +0200, Alban Bedel wrote:
> I was playing with subtitles autoload and i found out that vobsub in
> ~/.mplayer/sub are not autoloaded. The first patch fix that.

Is missing at least a check for psub == NULL.

> Another little bugger is ao oss when used with several dsp. One can
> use -ao oss,oss:/dev/dsp1 to get fallback from one dsp on the other.
> But then the mixer settings (device and/or channel) are wrong when using
> the second dsp. So i made a little patch to allow setting mixer device
> and channel "per instance". The syntax become:

Nice, but IMHO the whole mixer_channel thing including the global
option should be removed. Also I think the suboption parser
should be used (see subopt-helper.h and e.g. vo_gl.c, preinit function
on how to use it).

Greetings,
Reimar DÃ¶ffinger