[MPlayer-dev-eng] [PATCH] af_pan: hard clipping, and more than 100% of source channels

[Reimar Döffinger]

Hi,
On Wed, Sep 14, 2005 at 07:58:04PM -0700, Corey Hickey wrote:
> > I vote for replacing 0.0 with -MAX_LVL, too.
> > Though explaining this in the man page might be a bit more difficult.

Actually I was wondering if it makes sense to restrict those values at
all, especially since the user isn't told that fact (it just clamps
them, no error message).
Any maximum value will be just an arbitrary choice without a good reason
in the end...

> It's kind of fun, so I've updated the patch with that change. Can anyone
> come up with good/amusing uses for it besides the two I've added to the
> docs?

Yes, emulating af_extrastereo with two filters :-P

> +<listitem><para>
> +For this example, we only need to work with two channels, so it is not
> +necessary to specifiy <option>-channels</option>.
> +<option>pan</option> will only be outputting a single channel, however,
> +so <option>,channels=1</option> should be appended afterward.
> +</para></listitem>

Actually I think that -channels should not be needed at all...
That was a bug in af_pan, I fixed it and removed also the restrictions
on the input parameters, so only the documentation part is still
needed :-)
The first parameter is the number of output channels now.

> +one channel it will not be able to interfere with another channel.

huh? I think you want to say you will not be able to hear the difference
(e.g. due to interference, if interference is the right word at all).

Greetings,
Reimar Döffinger