[MPlayer-dev-eng] [PATCH] af_pan: hard clipping, and more than 100% of source channels

[Reimar Döffinger]

Hi,
On Fri, Sep 02, 2005 at 06:04:00PM -0700, Corey Hickey wrote:
> If attached a patch to use hard clipping the same way af_volume does,
> and to print a verbose-level message whenever it has to.

I am against this. If you use af_pan correctly this will not be
necessary and eat CPU. Since the output is floats you should be able to
get the same effect by just adding the volume filter after it if
necessary.
Also this clipping is really bad, a seperate clipping filter that
implement some really good algorithms would be nice.
Actually af_volume actually can do soft-clipping, though I seem to
remember somebody said it was broken.

> With this implemented, pan's limit of only being able to use 100% of a
> source channel seems to be an artificial restriction. I raised the limit
> to 51200%, which is approximately the same volume increase I can get
> from af_volume on a quiet movie. This should be way, way, way more than
> anybody will ever need.

Agree with this change.

Greetings,
Reimar Döffinger