[MPlayer-dev-eng] [PATCH] SGI IRIX audio format fixes

[dega]

> On Fri, 2 Sep 2005, Reimar [iso-8859-1] Döffinger wrote:
>
> > > +  switch(*format & (AF_FORMAT_POINT_MASK | AF_FORMAT_SPECIAL_MASK)) {
> > > +  case AF_FORMAT_I:
> >
> > IMHO you shouldn't use the low-level representation. If possible use the
> > predefined formats like AF_FORMAT_U16_LE etc.
>
> I was trying to get away from having to list EVERY possible combination of
> size, int/float, signed/unsigned in the switch statement. If using
> low-level representation is considered a no-no, then I will change this
> function at the expense of an unwieldy switch statement and some code
> duplication.

Nothing in af_format.h indicates which #defines are meant for public use,
and which ones are considered 'internal'. If there is a distinction
between low-level and high-level #defines, then there should at least be
a comment to that effect somewhere in af_format.h. Ideally, the non-public
#defines should be in a separate header file.

Does this make sense?

Thanks
dega