[MPlayer-dev-eng] [PATCH] af_pan: hard clipping, and more than 100% of source channels

[Corey Hickey]

With af_pan it is currently possible to exceed the proper range of float
values to be passed to the sound driver, resulting in unpleasant clicks.

$ mplayer file.mp3 -af pan=2:1:1:1:1

If attached a patch to use hard clipping the same way af_volume does,
and to print a verbose-level message whenever it has to.

---

With this implemented, pan's limit of only being able to use 100% of a
source channel seems to be an artificial restriction. I raised the limit
to 51200%, which is approximately the same volume increase I can get
from af_volume on a quiet movie. This should be way, way, way more than
anybody will ever need.

$ mplayer file.avi -af volume=60

Sounds absolutely horrible from the clipping, and so does:

$ mplayer file.avi -af pan=2:512:0:0:512

Values closer to 8 still sound ok. :)

-Corey
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pan-increase.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050902/a80b8d98/attachment.asc>