[MPlayer-dev-eng] [PATCH] DVD playback
Lehel Bernadt
lehel at pmc-services.hu
Sat Sep 3 13:35:48 CEST 2005
> Hi,
>
> > Here's the fix for another bug: mplayer always assumes that a title is
> > title number 1 in its titleset. In case of a titleset (VTS_NN_*.VOB )
> > with multiple titles, this is of course not the case.
> >
> > Since there was no feedback about my previous patch (subtitle/audio
> > mapping), I'm sending a diff with both set of changes included.
>
> You may submit the libdvdread parts to the libdvdread project first. So
> we dont need to maintain a patchset, and other players can make a use of
> this feature.
>
> And please dont merge two different patches, so could you send two
> separated patches now?
If you like to solve merge conflicts yourself, fine :)
They were merged because they patch some common code, and my first patch
wasn't applied to the cvs.
But for the time being, apply only the title playback fix which is attached.
The other one messes with libdvdread, for which I had defined two new
structures. However I checked how ogle and xine handle stream mapping, and it
turns out they do it fine, but they use the whole 16/32 bit values and
shift / and them with bitmasks. Not the most clear way to do things, but it
might prevent us to replace the values with structures.
>
> --
> Alex Beregszaszi email: alex at fsn.hu
> Free Software Network cell: +36 70 3144424
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-dvd-title.patch.gz
Type: application/x-gzip
Size: 861 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050903/8aab8ca6/attachment.bin>
More information about the MPlayer-dev-eng
mailing list