[MPlayer-dev-eng] [PATCH] move setenv implementation to osdep/

[Rich Felker]

On Fri, Oct 28, 2005 at 10:53:01PM +0200, Alexander Strasser wrote:
> Hi,
> 
> Rich Felker wrote:
> > On Thu, Oct 27, 2005 at 11:30:03AM +0200, Alexander Strasser wrote:
> [...]
> > > > Index: configure
> > > > ===================================================================
> > > > +/* Define this if your system has setenv */
> > > > +$_def_setenv
> > > > +
> > > 
> > >   I think the systems missing setenv don't have a
> > > prototype in stdlib.h for it, so we need to provide
> > > one else where.
> > 
> > Why? Nothing says you need a prototype. In fact setenv has the default
> > return type (int) so it's especially useless.
> 
>   Strictly speaking you are right, but i think it is still
> an advantage to have the compiler doing param checking.

It will do param checking anyway on all sane systems, just not
extremely broken ones missing setenv. I assume no one actually
develops new code on such systems..

Rich