[MPlayer-dev-eng] [PATCH] move setenv implementation to osdep/
Alexander Strasser
eclipse7 at gmx.net
Fri Oct 28 22:53:01 CEST 2005
Hi,
Rich Felker wrote:
> On Thu, Oct 27, 2005 at 11:30:03AM +0200, Alexander Strasser wrote:
[...]
> > > Index: configure
> > > ===================================================================
> > > +/* Define this if your system has setenv */
> > > +$_def_setenv
> > > +
> >
> > I think the systems missing setenv don't have a
> > prototype in stdlib.h for it, so we need to provide
> > one else where.
>
> Why? Nothing says you need a prototype. In fact setenv has the default
> return type (int) so it's especially useless.
Strictly speaking you are right, but i think it is still
an advantage to have the compiler doing param checking.
[...]
Ah and i forgot to mention some other changes, i removed
the huge amount of tabs in setenv.c and included config.h
as the code was #ifdef'd to be conditionally compiled.
Alex (beastd)
More information about the MPlayer-dev-eng
mailing list