[MPlayer-dev-eng] [PATCH] behaviour of 'a' key and sub alignment

[Paul TT]

On Mon, 24 Oct 2005 12:36:24 -0400
Rich Felker <dalias at aerifal.cx> wrote:

> On Mon, Oct 24, 2005 at 05:04:19PM +0200, Paul TT wrote:
> > On Sun, 23 Oct 2005 16:25:00 +0200
> > Diego Biurrun <diego at biurrun.de> wrote:
> > 
> > > On Sun, Oct 23, 2005 at 03:26:42PM +0200, Paul TT wrote:
> > > > 
> > > > in libvo/sub.c the forst condition about sub aligment equals to
2,
> > then
> > > > acted as if compared to 0.....
> > > 
> > > Thanks, applied.
> > 
> > mhhh, no, the default value of sub_alignemnt only was changed. the
> > alignment of subs while playing still works exactly up-down as
before.
> > I read about IRC discussion in the other thread, but the result is
that
> > when i am playing something with subs and i press 'a' it still tell
me
> > 'bottom' when they are top-aligned and 'top' when they're
> > bottom-aligned.....
> 
> RTFM; you're just misunderstanding the word "align". Subs have always
> been correctly aligned.

mhhh, in TFM there is no definition of 'align'...
it's only specified the meaning of 0,1,2
AFAIK top means above, bottom means below.
so if this is right mplayer works wrong.

if the following is the area of the subs:
+---------+
|         |
|         |
|         |
+---------+
the way mplayer subalign works is as it follows:
     +---------+
2->  |subtitle2|
1->  |subtitle1|
0->  |subtitle0|
     +---------+

and this way works the 'a' key switch.
but when the sub is at top, as TFM says, it should be at 0, instead 0
is renderered as the bottom... 
and 2 as top position, and this conflicts with TFM. so or TFM is wrong
or libvo/subs.c goes wrong.
try with:
mplayer -subpos 50 -subalign 0 file_with_subs.avi
and then switch the alignment....